[GitHub] incubator-nifi pull request: Correcting the capability description...

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-nifi pull request: Correcting the capability description...

JPercivall
GitHub user apiri opened a pull request:

    https://github.com/apache/incubator-nifi/pull/25

    Correcting the capability description which states that the property is ...

    ...ignored when destination is flowfile attribute instead of content.  This closes NIFI-356.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apiri/incubator-nifi NIFI-356

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-nifi/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #25
   
----
commit 24be4a1dfdd1dd513e39915c5db8939d4806cdd8
Author: Aldrin Piri <[hidden email]>
Date:   2015-02-17T05:20:23Z

    Correcting the capability description which states that the property is ignored when destination is flowfile attribute instead of content.  This closes NIFI-356.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-nifi pull request: Correcting the capability description...

JPercivall
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-nifi/pull/25


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-nifi pull request: Correcting the capability description...

JPercivall
In reply to this post by JPercivall
Github user busbey commented on the pull request:

    https://github.com/apache/incubator-nifi/pull/25#issuecomment-74619179
 
    Hi Apiri!
   
    Thanks for the correction. Could you begin the commit message with NIFI-356 rather than at the end?
   
    e.g.
   
    "NIFI-356 Correct capability description for EvaluateXPath.
   
    Update the capability description to state that the property is ignored when the destination is flowfile-attribute."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-nifi pull request: Correcting the capability description...

JPercivall
In reply to this post by JPercivall
Github user busbey commented on the pull request:

    https://github.com/apache/incubator-nifi/pull/25#issuecomment-74619266
 
    Looks like I was too slow. Thanks again Apiri.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-nifi pull request: Correcting the capability description...

JPercivall
In reply to this post by JPercivall
Github user joewitt commented on the pull request:

    https://github.com/apache/incubator-nifi/pull/25#issuecomment-74619585
 
    We are good with the ticket ref anywhere in the message:
    "https://www.apache.org/dev/svngit2jira.html with the trigger activating on the present of a NIFI-### anywhere in the commmit message"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-nifi pull request: Correcting the capability description...

JPercivall
In reply to this post by JPercivall
Github user busbey commented on the pull request:

    https://github.com/apache/incubator-nifi/pull/25#issuecomment-74619659
 
    Sure, it's just much easier to scan through commits when the tickets are at the start, especially in an abbreviated git history.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-nifi pull request: Correcting the capability description...

JPercivall
In reply to this post by JPercivall
Github user joewitt commented on the pull request:

    https://github.com/apache/incubator-nifi/pull/25#issuecomment-74619737
 
    Understood.  I was just trying to find a non abbrev form of this when your note came in.  So totally with you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---