[GitHub] incubator-nifi pull request: NIFI-548

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-nifi pull request: NIFI-548

JPercivall
GitHub user bbende opened a pull request:

    https://github.com/apache/incubator-nifi/pull/48

    NIFI-548

    This pull request shows a possible approach to support "FlowFile per Datagram" for NIFI-548.
   
    Most of the changes are for passing down a flag from the processor all the way to the DatagramChannelReader which requires passing through a few levels of classes.
   
    The important change to the logic is:
    * DatagramChannelReader - break out of the receive loop if null, or if we only want one datagram
    * UDPConsumerCallback - break out of writing to the FlowFile OutputStream if we hit the totalBytes, or if we only want one datagram

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bbende/incubator-nifi NIFI-548

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-nifi/pull/48.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #48
   
----
commit 8d4c8f6899a63a2b6bbe1503825cd01e6763c5cc
Author: bbende <[hidden email]>
Date:   2015-04-30T00:53:18Z

    Initial changes to pass down a property from ListenUDP to the DatagramReader for one FlowFile per datagram

commit 37c6facc69c469c486c6205e38aaa0972af8077e
Author: bbende <[hidden email]>
Date:   2015-04-30T01:29:10Z

    Updating UDPConsumerCallback to consider use the FlowFile-Per-Datagram property

commit cbe8e694f6717ae3d0b3aca62d4b84403d9ac51b
Author: bbende <[hidden email]>
Date:   2015-05-01T01:00:00Z

    Merge remote-tracking branch 'upstream/develop' into NIFI-548

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-nifi pull request: NIFI-548

JPercivall
Github user busbey commented on the pull request:

    https://github.com/apache/incubator-nifi/pull/48#issuecomment-99355606
 
    please update the commit message to reference the jira. please squash to a single commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-nifi pull request: NIFI-548

JPercivall
In reply to this post by JPercivall
Github user bbende closed the pull request at:

    https://github.com/apache/incubator-nifi/pull/48


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---