[GitHub] incubator-nifi pull request: Nifi 280 take three

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-nifi pull request: Nifi 280 take three

JPercivall
GitHub user danbress opened a pull request:

    https://github.com/apache/incubator-nifi/pull/19

    Nifi 280 take three

    Wrote a little CSS to format the tables better, and changed which columns appear in the table.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/danbress/incubator-nifi NIFI-280-take2-tworow

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-nifi/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19
   
----
commit d7cf25be9a157f6934593a325f906a0fc85e4007
Author: danbress <[hidden email]>
Date:   2015-01-31T14:02:23Z

    NIFI-280 - Adding new documentation framework component and incorporating
    in framework

commit 220fcac169ce180ef0ad34a3d0080a1b03e337a7
Author: danbress <[hidden email]>
Date:   2015-01-31T17:29:07Z

    NIFI-280 rewording column headers and warning message

commit 0fa553ac0265f96cb5c2a5f42bc760aa0c65b590
Author: danbress <[hidden email]>
Date:   2015-01-31T17:56:25Z

    NIFI-280 - Modifing existing existing documentation
    removing index.html and renaming to additionalDetails.html if there is relevent information

commit f269861d9d5b7e1d2a54750840831239a16490d1
Author: danbress <[hidden email]>
Date:   2015-02-03T02:01:57Z

    NIFI-280 - removing apache license from generated HTML

commit 60070706281e8d8cd8ee2a15312f62a1af9e7e0c
Author: danbress <[hidden email]>
Date:   2015-02-04T03:37:44Z

    NIFI-280 - putting description as an info bubble

commit 5f1fb45c91911fffd58e5ab8b4403265236d9b27
Author: danbress <[hidden email]>
Date:   2015-02-04T03:51:17Z

    NIFI-280 writing the description as a second row

commit c3085b8b21501c48c8debf504a6ce893af552dc8
Author: danbress <[hidden email]>
Date:   2015-02-04T04:18:43Z

    NIFI-280 - fixing colspan

commit 6e80ae7b9bc95c86bc907823be4eb0dd41a369e2
Author: danbress <[hidden email]>
Date:   2015-02-06T00:52:04Z

    NIFI-280 - changing the way properties are formatted

commit 4ab278dd197c81e40b73f70e03fbb71997be6823
Author: danbress <[hidden email]>
Date:   2015-02-07T16:51:04Z

    NIFI-280 fixing up table formatting of tables in components

commit 9552b189c9861d4eb54bb7a2a569e1447c13332a
Author: danbress <[hidden email]>
Date:   2015-02-07T16:51:18Z

    NIFI-280 - creating some example to test formatting

commit ef6d76cbd92b96c8eb9c5d45f0189888c63d8fb9
Author: danbress <[hidden email]>
Date:   2015-02-07T16:54:01Z

    NIFI-280 - reducing table padding

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-nifi pull request: Nifi 280 take three

JPercivall
Github user joewitt commented on the pull request:

    https://github.com/apache/incubator-nifi/pull/19#issuecomment-73396246
 
    Dan,
   
    Don't recall if you and Mark chatted about this previously but the name 'nifi-documentation' might be confusing.  There is already a 'nifi-docs' project.  Could perhaps this just be rolled into the existing 'nifi-docs' project?  
   
    The next thing you choose to tackle i hope is much easier so you don't have to go through these rounds of fun.  Thanks for sticking with it
   
    Joe


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-nifi pull request: Nifi 280 take three

JPercivall
In reply to this post by JPercivall
Github user danbress commented on the pull request:

    https://github.com/apache/incubator-nifi/pull/19#issuecomment-76871131
 
    Hey guys,
       Wanted to check in on this.  Are you waiting for me to do something here?  Do you want me to try and move the changes into nifi-docs?  Or are we still waiting for 0.0.2 to be released so this can be merged into 0.1.0?
   
       If there is anything I can do to help let me know.  I don't want to wait too long and have the pull/merge get painful if things continue to change on develop.
   
    Dan


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] incubator-nifi pull request: Nifi 280 take three

Mark Payne
In reply to this post by JPercivall
Dan,


We’re still waiting on the 0.0.2 to get pushed out. At this moment there are no more tickets against 0.0.2 - it’s probably about time to start voting 😊


THanks

-Mark






From: danbress
Sent: ‎Monday‎, ‎March‎ ‎2‎, ‎2015 ‎8‎:‎48‎ ‎PM
To: [hidden email]





Github user danbress commented on the pull request:

    https://github.com/apache/incubator-nifi/pull/19#issuecomment-76871131
 
    Hey guys,
       Wanted to check in on this.  Are you waiting for me to do something here?  Do you want me to try and move the changes into nifi-docs?  Or are we still waiting for 0.0.2 to be released so this can be merged into 0.1.0?
   
       If there is anything I can do to help let me know.  I don't want to wait too long and have the pull/merge get painful if things continue to change on develop.
   
    Dan


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-nifi pull request: Nifi 280 take three

JPercivall
In reply to this post by JPercivall
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-nifi/pull/19


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---