[GitHub] incubator-nifi pull request: Re-write of volatile repository

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-nifi pull request: Re-write of volatile repository

JPercivall
GitHub user BELUGABEHR opened a pull request:

    https://github.com/apache/incubator-nifi/pull/64

    Re-write of volatile repository

    Simplified the code base
    Removes some proprietary code in favor of Apache Commons framework
    Removes unnecessary thread pools
    Enhanced unit test code coverage
    Fixed some comments in the API Interface

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BELUGABEHR/incubator-nifi Prov-Volatile

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-nifi/pull/64.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #64
   
----
commit 12710e86547584324ea0a15580fc89e7f70336ed
Author: BELUGABEHR <[hidden email]>
Date:   2015-05-28T00:25:39Z

    Re-write of volatile repository

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-nifi pull request: Re-write of volatile repository

JPercivall
Github user danbress commented on a diff in the pull request:

    https://github.com/apache/incubator-nifi/pull/64#discussion_r31661933
 
    --- Diff: nifi/nifi-commons/nifi-data-provenance-utils/src/main/java/org/apache/nifi/provenance/FilterProvenanceEventRecord.java ---
    @@ -0,0 +1,169 @@
    +package org.apache.nifi.provenance;
    --- End diff --
   
    Needs the ASF License


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-nifi pull request: Re-write of volatile repository

JPercivall
In reply to this post by JPercivall
Github user danbress commented on a diff in the pull request:

    https://github.com/apache/incubator-nifi/pull/64#discussion_r31661948
 
    --- Diff: nifi/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-volatile-provenance-repository/src/main/java/org/apache/nifi/provenance/IdEnrichedProvenanceEvent.java ---
    @@ -0,0 +1,51 @@
    +package org.apache.nifi.provenance;
    --- End diff --
   
    Needs the ASF License


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-nifi pull request: Re-write of volatile repository

JPercivall
In reply to this post by JPercivall
Github user danbress commented on the pull request:

    https://github.com/apache/incubator-nifi/pull/64#issuecomment-108593514
 
    @BELUGABEHR Thanks for another contribution.  
   
    Can you open a JIRA Ticket (https://issues.apache.org/jira/browse/NIFI) explaining the change, and reference the ticket in the title of your pull request?
   
    Thanks again!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-nifi pull request: Re-write of volatile repository

JPercivall
In reply to this post by JPercivall
Github user BELUGABEHR closed the pull request at:

    https://github.com/apache/incubator-nifi/pull/64


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---