Proper way to finish a review

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Proper way to finish a review

Mike Thomsen
When I am satisfied with a review, should I choose approve or the option to
just leave comment and ping some folks on the PMC to come see if they want
to sign off for merging?

Thanks,

Mike
Reply | Threaded
Open this post in threaded view
|

Re: Proper way to finish a review

Joe Witt
Mike

Thanks for jumping in to the review game.  We definitely need the help!

I'd say leave your comments/+1 for things that you've reviewed and
validated and you think are ready to merge.  Then anyone with commit
privileges can take that and get it pushed in.  On your reviews please
try to let it be known to what level you're confident.  Ideally a +1
would mean you've done a full clean build with contrib check, any new
tests that come with it are passing, that the code looks good, and
that you've had a chance to run it and verify the behavior yourself.
Some things are harder to review than others for sure but every bit
helps.

Thanks

On Wed, Oct 25, 2017 at 7:43 AM, Mike Thomsen <[hidden email]> wrote:
> When I am satisfied with a review, should I choose approve or the option to
> just leave comment and ping some folks on the PMC to come see if they want
> to sign off for merging?
>
> Thanks,
>
> Mike