RE: #JIRA NIFI-5327 #PR 2820

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

RE: #JIRA NIFI-5327 #PR 2820

V, Prashanth (Nokia - IN/Bangalore)
Team,
1.      JIRA NIFI-5327<https://issues.apache.org/jira/browse/NIFI-5327> - PR NIFI-5327 Adding Netflowv5 protocol parser<https://github.com/apache/nifi/pull/2820>
2.      I didn't get feedback on this PR. Does anyone able to review this PR?

Thanks & Regards,
Prashanth
Reply | Threaded
Open this post in threaded view
|

Re: #JIRA NIFI-5327 #PR 2820

Joe Witt
prasanth

it looks like a great addition.  reviews and merges can take quite a bit of
time depending on the size, complexity, difficulty in testing,security
relevance, availability of reviewers with expertise in that area.  Keep in
mind the community has gone through many votes too.  We have many
outstanding PRs at this time.

The process can take a while so please be patient.  In the mean time
consider reviewing others contributions as well as this can help greatly.

Thanks

On Tue, Jul 3, 2018, 7:00 AM V, Prashanth (Nokia - IN/Bangalore) <
[hidden email]> wrote:

> Team,
> 1.      JIRA NIFI-5327<https://issues.apache.org/jira/browse/NIFI-5327> -
> PR NIFI-5327 Adding Netflowv5 protocol parser<
> https://github.com/apache/nifi/pull/2820>
> 2.      I didn't get feedback on this PR. Does anyone able to review this
> PR?
>
> Thanks & Regards,
> Prashanth
>
Reply | Threaded
Open this post in threaded view
|

Re: #JIRA NIFI-5327 #PR 2820

Mike Thomsen
Prashanth,

Knowing nothing about the problem domain, I would recommend that you set up
things like Docker Compose files and sample flows that can be used to help
test. That's particularly true where the processors or controller services
deal with products that the majority of the community has little to no
experience with.

On Tue, Jul 3, 2018 at 8:11 AM Joe Witt <[hidden email]> wrote:

> prasanth
>
> it looks like a great addition.  reviews and merges can take quite a bit of
> time depending on the size, complexity, difficulty in testing,security
> relevance, availability of reviewers with expertise in that area.  Keep in
> mind the community has gone through many votes too.  We have many
> outstanding PRs at this time.
>
> The process can take a while so please be patient.  In the mean time
> consider reviewing others contributions as well as this can help greatly.
>
> Thanks
>
> On Tue, Jul 3, 2018, 7:00 AM V, Prashanth (Nokia - IN/Bangalore) <
> [hidden email]> wrote:
>
> > Team,
> > 1.      JIRA NIFI-5327<https://issues.apache.org/jira/browse/NIFI-5327>
> -
> > PR NIFI-5327 Adding Netflowv5 protocol parser<
> > https://github.com/apache/nifi/pull/2820>
> > 2.      I didn't get feedback on this PR. Does anyone able to review this
> > PR?
> >
> > Thanks & Regards,
> > Prashanth
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: #JIRA NIFI-5327 #PR 2820

Otto Fowler
Do we have any kind of guide or blog to refer to for this?


On July 3, 2018 at 08:21:39, Mike Thomsen ([hidden email]) wrote:

Prashanth,

Knowing nothing about the problem domain, I would recommend that you set up
things like Docker Compose files and sample flows that can be used to help
test. That's particularly true where the processors or controller services
deal with products that the majority of the community has little to no
experience with.

On Tue, Jul 3, 2018 at 8:11 AM Joe Witt <[hidden email]> wrote:

> prasanth
>
> it looks like a great addition. reviews and merges can take quite a bit
of

> time depending on the size, complexity, difficulty in testing,security
> relevance, availability of reviewers with expertise in that area. Keep in
> mind the community has gone through many votes too. We have many
> outstanding PRs at this time.
>
> The process can take a while so please be patient. In the mean time
> consider reviewing others contributions as well as this can help greatly.
>
> Thanks
>
> On Tue, Jul 3, 2018, 7:00 AM V, Prashanth (Nokia - IN/Bangalore) <
> [hidden email]> wrote:
>
> > Team,
> > 1. JIRA NIFI-5327<https://issues.apache.org/jira/browse/NIFI-5327>
> -
> > PR NIFI-5327 Adding Netflowv5 protocol parser<
> > https://github.com/apache/nifi/pull/2820>
> > 2. I didn't get feedback on this PR. Does anyone able to review this
> > PR?
> >
> > Thanks & Regards,
> > Prashanth
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: #JIRA NIFI-5327 #PR 2820

Mike Thomsen
Not sure, but if we don't it would be a good idea. People often overlook
the learning curve issue.

On Tue, Jul 3, 2018 at 11:31 AM Otto Fowler <[hidden email]> wrote:

> Do we have any kind of guide or blog to refer to for this?
>
>
> On July 3, 2018 at 08:21:39, Mike Thomsen ([hidden email]) wrote:
>
> Prashanth,
>
> Knowing nothing about the problem domain, I would recommend that you set
> up
> things like Docker Compose files and sample flows that can be used to help
> test. That's particularly true where the processors or controller services
> deal with products that the majority of the community has little to no
> experience with.
>
> On Tue, Jul 3, 2018 at 8:11 AM Joe Witt <[hidden email]> wrote:
>
> > prasanth
> >
> > it looks like a great addition. reviews and merges can take quite a bit
> of
> > time depending on the size, complexity, difficulty in testing,security
> > relevance, availability of reviewers with expertise in that area. Keep
> in
> > mind the community has gone through many votes too. We have many
> > outstanding PRs at this time.
> >
> > The process can take a while so please be patient. In the mean time
> > consider reviewing others contributions as well as this can help
> greatly.
> >
> > Thanks
> >
> > On Tue, Jul 3, 2018, 7:00 AM V, Prashanth (Nokia - IN/Bangalore) <
> > [hidden email]> wrote:
> >
> > > Team,
> > > 1. JIRA NIFI-5327<https://issues.apache.org/jira/browse/NIFI-5327>
> > -
> > > PR NIFI-5327 Adding Netflowv5 protocol parser<
> > > https://github.com/apache/nifi/pull/2820>
> > > 2. I didn't get feedback on this PR. Does anyone able to review this
> > > PR?
> > >
> > > Thanks & Regards,
> > > Prashanth
> > >
> >
>
>
Reply | Threaded
Open this post in threaded view
|

RE: #JIRA NIFI-5327 #PR 2820

V, Prashanth (Nokia - IN/Bangalore)
@Joe I am new to the contribution and hence wanted to know about the process. I understand your point. I will wait..
@Mike , @Otto - Your suggestion is good. I will update the PR with NiFi template, packet generator and some relevant links to understand and test this processor.

Thanks & Regards,
Prashanth

-----Original Message-----
From: Mike Thomsen [mailto:[hidden email]]
Sent: Tuesday, July 03, 2018 9:25 PM
To: Otto Fowler <[hidden email]>
Cc: [hidden email]
Subject: Re: #JIRA NIFI-5327 #PR 2820

Not sure, but if we don't it would be a good idea. People often overlook
the learning curve issue.

On Tue, Jul 3, 2018 at 11:31 AM Otto Fowler <[hidden email]> wrote:

> Do we have any kind of guide or blog to refer to for this?
>
>
> On July 3, 2018 at 08:21:39, Mike Thomsen ([hidden email]) wrote:
>
> Prashanth,
>
> Knowing nothing about the problem domain, I would recommend that you set
> up
> things like Docker Compose files and sample flows that can be used to help
> test. That's particularly true where the processors or controller services
> deal with products that the majority of the community has little to no
> experience with.
>
> On Tue, Jul 3, 2018 at 8:11 AM Joe Witt <[hidden email]> wrote:
>
> > prasanth
> >
> > it looks like a great addition. reviews and merges can take quite a bit
> of
> > time depending on the size, complexity, difficulty in testing,security
> > relevance, availability of reviewers with expertise in that area. Keep
> in
> > mind the community has gone through many votes too. We have many
> > outstanding PRs at this time.
> >
> > The process can take a while so please be patient. In the mean time
> > consider reviewing others contributions as well as this can help
> greatly.
> >
> > Thanks
> >
> > On Tue, Jul 3, 2018, 7:00 AM V, Prashanth (Nokia - IN/Bangalore) <
> > [hidden email]> wrote:
> >
> > > Team,
> > > 1. JIRA NIFI-5327<https://issues.apache.org/jira/browse/NIFI-5327>
> > -
> > > PR NIFI-5327 Adding Netflowv5 protocol parser<
> > > https://github.com/apache/nifi/pull/2820>
> > > 2. I didn't get feedback on this PR. Does anyone able to review this
> > > PR?
> > >
> > > Thanks & Regards,
> > > Prashanth
> > >
> >
>
>