Re: [GitHub] incubator-nifi pull request: NIFI-238: Add Kite processors.

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] incubator-nifi pull request: NIFI-238: Add Kite processors.

Mark Payne
Ryan,


You replied quite a while ago about this, but I’ve been a bit behind. I created https://issues.apache.org/jira/browse/NIFI-393 to address the feedback you provided, to update the developer guide to make some things more clear.


Thanks for taking the time

-Mark






From: Ryan Blue
Sent: ‎Monday‎, ‎February‎ ‎23‎, ‎2015 ‎12‎:‎00‎ ‎AM
To: [hidden email]





On 02/19/2015 04:44 PM, Mark Payne wrote:
> Ryan,
>
>
> Excellent - Looking forward to getting this pulled in as soon as I get a chance!

Thanks for your help! I'm looking forward to getting these in.

> If you get a minute to provide feedback I’m really interested in what you think of developing processors. Where do we need better documentation? What did you like or not like about the API? What was confusing / not intuitive, etc.? Was there something you felt was missing?

The reviews and help were great, since I started before the guide was
available. Even with the guide, it was a little difficult to know what I
should let the framework handle for me, especially given that the review
comments helped me fix some things I copied from elsewhere (like
catching Throwable). Maybe a good example processor would help.

Overall, the API makes sense and works well. It is somewhat strange to
use a callback to write data (though I can see why) and maybe some
explanation would help there.

There is some great stuff in the developer guide, but it is a big chunk
of text. I think it could use some diagrams and maybe be broken into
several pages that are cross-linked. Examples are always good too, like
when you would use certain annotations and what to watch out for (like
using volatile for fields set in @OnScheduled).

I hope that helps, I'll have to take a closer look at the current guide
since I had already gotten started when I read it. Thanks for all your help!

rb


--
Ryan Blue
Software Engineer
Cloudera, Inc.