Two pull requests

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Two pull requests

Mike Thomsen
https://github.com/apache/nifi/pull/2063

I've been using this one for a little while with a client and another
internal project. It generates JSON with a standard structure instead of
the way Mongo generates JSON by default with the Java driver. Compatibility
is maintained via an option on how to generate JSON.

https://github.com/apache/nifi/pull/2104

I just added this today. It's support for Kotlin in ExecuteScript. (I might
need to update some documentation because Kotlin has some peculiarities
about injecting variables)

If someone could take a look at them, I'd appreciate it.

Thanks,

Mike
Reply | Threaded
Open this post in threaded view
|

Re: Two pull requests

Matt Burgess-2
Mike,

I left a comment on the Kotlin PR, I will try to review that this
week. I also pushed a branch of the work I had done to add Kotlin as
well [1], if you find anything useful to include, please feel free to
take any/all/none of it :)

Regards,
Matt

[1] https://github.com/apache/nifi/compare/master...mattyb149:kotlin-scripting?expand=1


On Mon, Aug 21, 2017 at 1:34 PM, Mike Thomsen <[hidden email]> wrote:

> https://github.com/apache/nifi/pull/2063
>
> I've been using this one for a little while with a client and another
> internal project. It generates JSON with a standard structure instead of
> the way Mongo generates JSON by default with the Java driver. Compatibility
> is maintained via an option on how to generate JSON.
>
> https://github.com/apache/nifi/pull/2104
>
> I just added this today. It's support for Kotlin in ExecuteScript. (I might
> need to update some documentation because Kotlin has some peculiarities
> about injecting variables)
>
> If someone could take a look at them, I'd appreciate it.
>
> Thanks,
>
> Mike
Reply | Threaded
Open this post in threaded view
|

Re: Two pull requests

Mike Thomsen
I just tested your branch and it works. However, Kotlin's JSR interface
seems to be running really slowly.

My opinion is your branch is ready to merge in place of mine to close the
ticket, but there should be an advisory that Kotlin is not a viable
scripting option right now for more than prototyping new features.

On Mon, Aug 21, 2017 at 1:46 PM, Matt Burgess <[hidden email]> wrote:

> Mike,
>
> I left a comment on the Kotlin PR, I will try to review that this
> week. I also pushed a branch of the work I had done to add Kotlin as
> well [1], if you find anything useful to include, please feel free to
> take any/all/none of it :)
>
> Regards,
> Matt
>
> [1] https://github.com/apache/nifi/compare/master...
> mattyb149:kotlin-scripting?expand=1
>
>
> On Mon, Aug 21, 2017 at 1:34 PM, Mike Thomsen <[hidden email]>
> wrote:
> > https://github.com/apache/nifi/pull/2063
> >
> > I've been using this one for a little while with a client and another
> > internal project. It generates JSON with a standard structure instead of
> > the way Mongo generates JSON by default with the Java driver.
> Compatibility
> > is maintained via an option on how to generate JSON.
> >
> > https://github.com/apache/nifi/pull/2104
> >
> > I just added this today. It's support for Kotlin in ExecuteScript. (I
> might
> > need to update some documentation because Kotlin has some peculiarities
> > about injecting variables)
> >
> > If someone could take a look at them, I'd appreciate it.
> >
> > Thanks,
> >
> > Mike
>
Reply | Threaded
Open this post in threaded view
|

Re: Two pull requests

Mike Thomsen
There's an option in there to generate a CompiledScript object that might
solve this. I'll take a look at that, but I think the Kotlin support should
be added so people can at least prototype with it.

On Mon, Aug 21, 2017 at 6:40 PM, Mike Thomsen <[hidden email]>
wrote:

> I just tested your branch and it works. However, Kotlin's JSR interface
> seems to be running really slowly.
>
> My opinion is your branch is ready to merge in place of mine to close the
> ticket, but there should be an advisory that Kotlin is not a viable
> scripting option right now for more than prototyping new features.
>
> On Mon, Aug 21, 2017 at 1:46 PM, Matt Burgess <[hidden email]>
> wrote:
>
>> Mike,
>>
>> I left a comment on the Kotlin PR, I will try to review that this
>> week. I also pushed a branch of the work I had done to add Kotlin as
>> well [1], if you find anything useful to include, please feel free to
>> take any/all/none of it :)
>>
>> Regards,
>> Matt
>>
>> [1] https://github.com/apache/nifi/compare/master...mattyb149:
>> kotlin-scripting?expand=1
>>
>>
>> On Mon, Aug 21, 2017 at 1:34 PM, Mike Thomsen <[hidden email]>
>> wrote:
>> > https://github.com/apache/nifi/pull/2063
>> >
>> > I've been using this one for a little while with a client and another
>> > internal project. It generates JSON with a standard structure instead of
>> > the way Mongo generates JSON by default with the Java driver.
>> Compatibility
>> > is maintained via an option on how to generate JSON.
>> >
>> > https://github.com/apache/nifi/pull/2104
>> >
>> > I just added this today. It's support for Kotlin in ExecuteScript. (I
>> might
>> > need to update some documentation because Kotlin has some peculiarities
>> > about injecting variables)
>> >
>> > If someone could take a look at them, I'd appreciate it.
>> >
>> > Thanks,
>> >
>> > Mike
>>
>
>